This repository has been archived by the owner on Oct 18, 2024. It is now read-only.
Moving from Ably to IOC #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossantos74
changed the title
carlossantos74
force-pushed
the
core/removing-ably
branch
from
e0f09d1 to
6c7ad48
Compare
|
Total Coverage: 94.56% Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Total Coverage: 97.36% Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Raspincel
reviewed
Jun 24, 2024
| }); | ||
| } | ||
| })(); | ||
|
|
There was a problem hiding this comment.
Is this comment still useful?
Raspincel
reviewed
Jun 24, 2024
| @@ -369,15 +366,16 @@ describe('Who Is Online', () => { | |||
| jest.clearAllMocks(); | |||
| }); | |||
|
|
|||
| test('should publish following data', () => { | |||
| const { following } = whoIsOnlineComponent['useStore'](StoreType.WHO_IS_ONLINE); | |||
| // test.only('should publish following data', () => { | |||
Raspincel
approved these changes
Jun 24, 2024
|
🎉 This PR is included in version 6.3.0-lab.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 6.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After moving all the components to IOC, we no longer use ably for any component or core feature, the last thing we use ably for is to validate the connection, which can also be done by IOC, so after this release we no longer start ably connection in our SDK.
We have also moved the network monitors to IOC, and handle updates to them in the IOC service, something like: force the connection to restart if the participant has lost it and is no longer able to reconnect.
There are other important changes, such as updating the package versions to the latest version and the node runtime version to the latest LTS version (20x).