This repository has been archived by the owner on Oct 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Improve slot assignment and de-assignment #707
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossantos74
changed the title
Implementing connection limits based on product limits
Improve slot assignment and de-assignment
Jul 9, 2024
carlossantos74
force-pushed
the
feat/connection-limits-per-product
branch
from
July 9, 2024 19:54
31b4079
to
5793d08
Compare
Raspincel
approved these changes
Jul 10, 2024
carlossantos74
force-pushed
the
feat/connection-limits-per-product
branch
from
July 10, 2024 12:33
aca6bf1
to
d36fd04
Compare
Total Coverage: 94.60% Coverage Report
|
Total Coverage: 97.35% Coverage Report
|
🎉 This PR is included in version 6.5.0-lab.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 6.5.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 6.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when a user entered the room, we would assign them a slot, now we only assign slots to users who need a slot.
Example: If a user is in real-time, they don't need a slot because it's not a slot for anything. But if a user is in WIO, they will need a slot because it's used to show what colour that user has.
To improve this logic, we observe the user list in the store, find what's component is active in this time, when has a component that need slot, we assign a slot to user. If it doesn't, we assign the default slot to the user, in this case the grey slot.
There is also an edge case, users that are only in video and the type is
audience
shouldn't have a slot too.