This repository has been archived by the owner on Oct 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Implement connection limits by product instead of by room #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Total Coverage: 94.60% Coverage Report
|
Total Coverage: 97.35% Coverage Report
|
carlossantos74
changed the title
feat: implement connection limits by product instead of by room
Implement connection limits by product instead of by room
Jul 10, 2024
Raspincel
approved these changes
Jul 11, 2024
🎉 This PR is included in version 6.5.0-lab.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 6.5.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 6.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before that, all the components have the same limit because it's implemented by room, it means all the components follow the maximum connections implemented by room, in this case it was 16 because it was the total slot count.
After that, the component has the limits by itself, it means we have components that can have more connections and component that can have less connections in the same room.
Example: if the client is using comments with video, they can connect 255 participants (between audience and guest/host) in the video room, but in the comments room they can only connect 50 participants.
It will allow more possibilities to the components because they will no longer be limited by the room.
To know what limits we have, and the price, visit: https://www.superviz.com/pricing