Skip to content
This repository was archived by the owner on Oct 18, 2024. It is now read-only.

fix: disconnect from drawing room when the video is destroyed #734

Merged
merged 4 commits into from
Aug 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/video/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import { Logger } from '../../common/utils';
import { BrowserService } from '../../services/browser';
import config from '../../services/config';
import { ConnectionService } from '../../services/connection-status';
import { RoomStateService } from '../../services/roomState';
import { RoomStateService } from '../../services/room-state';
import VideoConferenceManager from '../../services/video-conference-manager';
import {
CamerasPosition,
Expand Down Expand Up @@ -184,6 +184,7 @@ export class VideoConference extends BaseComponent {
destroy();

this.roomState?.destroy();
this.drawingRoom.disconnect();

this.kickParticipantsOnHostLeave = false;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,7 @@ export class RoomStateService {
public destroy() {
this.room.presence.off(PresenceEvents.LEAVE);
this.room.presence.off(PresenceEvents.JOINED_ROOM);
this.drawingRoom.presence.off(PresenceEvents.UPDATE);

this.room.off(RoomPropertiesEvents.UPDATE, this.updateLocalRoomState);
}
Expand Down
Loading