Skip to content

Commit

Permalink
add .eslintrc, lint fixes + jsdoc documentation (#1)
Browse files Browse the repository at this point in the history
  • Loading branch information
matthewgoslett authored May 4, 2017
1 parent 9a435a8 commit eef7ef0
Show file tree
Hide file tree
Showing 7 changed files with 89 additions and 15 deletions.
15 changes: 15 additions & 0 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"extends": "google",
"env": {
"node": true,
"es6": true
},
"rules": {
"max-len": ["error", {
"ignoreComments": true,
"ignoreUrls": true,
"ignoreStrings": true,
"ignoreRegExpLiterals": true
}]
}
}
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ npm install @superbalist/js-pubsub-redis
## Usage

```node
"use strict";
'use strict';

var redis = require('redis');
var RedisPubSubAdapter = require('@superbalist/js-pubsub-redis');
let redis = require('redis');
let RedisPubSubAdapter = require('@superbalist/js-pubsub-redis');

let client = redis.createClient({
host: 'redis',
Expand Down
8 changes: 4 additions & 4 deletions examples/RedisConsumerExample.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
"use strict";
'use strict';

var redis = require('redis');
var RedisPubSubAdapter = require('../src/RedisPubSubAdapter');
let redis = require('redis');
let RedisPubSubAdapter = require('../src/RedisPubSubAdapter');

let client = redis.createClient({
host: 'redis',
port: 6379
port: 6379,
});

let adapter = new RedisPubSubAdapter(client);
Expand Down
8 changes: 4 additions & 4 deletions examples/RedisPublishExample.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
"use strict";
'use strict';

var redis = require('redis');
var RedisPubSubAdapter = require('../src/RedisPubSubAdapter');
let redis = require('redis');
let RedisPubSubAdapter = require('../src/RedisPubSubAdapter');

let client = redis.createClient({
host: 'redis',
port: 6379
port: 6379,
});

let adapter = new RedisPubSubAdapter(client);
Expand Down
6 changes: 4 additions & 2 deletions index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
"use strict";
'use strict';

var RedisPubSubAdapter = require('./src/RedisPubSubAdapter');
/** @module pubsubRedis */

let RedisPubSubAdapter = require('./src/RedisPubSubAdapter');

module.exports = RedisPubSubAdapter;
4 changes: 4 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,9 @@
"dependencies": {
"@superbalist/js-pubsub": "0.0.1",
"redis": "^2.7.1"
},
"devDependencies": {
"eslint": "^3.19.0",
"eslint-config-google": "^0.7.1"
}
}
57 changes: 55 additions & 2 deletions src/RedisPubSubAdapter.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,50 @@
"use strict";
'use strict';

var Utils = require('@superbalist/js-pubsub').Utils;
let Utils = require('@superbalist/js-pubsub').Utils;

/**
* @callback subscriberCallback
* @param {*} message - The message payload received
*/

/**
* RedisPubSubAdapter Class
*
* @implements {module:pubsub.PubSubAdapterInterface}
* @example
* let redis = require('redis');
* let RedisPubSubAdapter = require('@superbalist/js-pubsub-redis');
*
* // create adapter
* let client = redis.createClient({
* host: 'redis',
* port: 6379,
* });
*
* let adapter = new RedisPubSubAdapter(client);
*/
class RedisPubSubAdapter {
/**
*
* @param {RedisClient} client
*/
constructor(client) {
/**
* @type {RedisClient}
*/
this.client = client;
}

/**
* Subscribe a handler to a channel.
*
* @param {string} channel
* @param {subscriberCallback} handler - The callback to run when a message is received
* @example
* adapter.subscribe('my_channel', (message) => {
* console.log(message);
* });
*/
subscribe(channel, handler) {
this.client.on('message', (channel, message) => {
handler(Utils.unserializeMessagePayload(message));
Expand All @@ -15,6 +53,21 @@ class RedisPubSubAdapter {
this.client.subscribe(channel);
}

/**
* Publish a message to a channel.
*
* @param {string} channel
* @param {*} message - The message payload
* @example
* // publish a string
* adapter.publish('my_channel', 'Hello World');
*
* // publish an object
* adapter.publish('my_channel', {
* 'id': 1234,
* 'first_name': 'Matthew',
* });
*/
publish(channel, message) {
this.client.publish(channel, message);
}
Expand Down

0 comments on commit eef7ef0

Please sign in to comment.