Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.

✨ Authentification without Json File #53

Merged
merged 6 commits into from
Apr 15, 2019

Conversation

rommni
Copy link
Contributor

@rommni rommni commented Mar 18, 2019

Allow users to authenticate to Google Cloud Storage, directly with env variable without using a json file.

@kedarv
Copy link

kedarv commented Mar 24, 2019

Thanks for doing this! Was having issues using file authentication, so this will make life a bit easier. Going to use your fork directly, but hopefully this can get fixed up and merged soon!

If anyone would like to use the branch here, in composer.json:

    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/rommni/laravel-google-cloud-storage"
        }
    ],
    "require": {
        "superbalist/laravel-google-cloud-storage": "dev-feature/gcsAuthByEnv",
    }

Note that there's a syntax issue as commented below.

Copy link
Contributor

@nicja nicja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, just a couple of comments on edge cases

src/GoogleCloudStorageServiceProvider.php Outdated Show resolved Hide resolved
src/GoogleCloudStorageServiceProvider.php Outdated Show resolved Hide resolved
src/GoogleCloudStorageServiceProvider.php Outdated Show resolved Hide resolved
Co-Authored-By: rommni <rombatie@hotmail.fr>
@nicja nicja merged commit 3b91702 into Superbalist:master Apr 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants