Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try fixing custom network related cors issues #96

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

donfrigo
Copy link
Contributor

@donfrigo donfrigo commented Nov 6, 2019

Description of the Change

Found a possible fix on Stackoverflow and on the web3 library github page, so in this PR the web3 library is rolled back to 0.20.6.

Issues

Relates to #55. Needs verifications.

@donfrigo donfrigo added the bug Something isn't working label Nov 6, 2019
Copy link
Contributor

@filippsen filippsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linked reports relate to a different error (Access-Control-Allow-Origin), so it is unclear how this change is going to solve the problem with CORS settings.

[test]

  • Compiles from scratch.
editor: Compiling...
editor: Compiled successfully!

OK

  • Double checking dapps after the package update:
    • HelloWorld: Compile, Deploy to Browser, Preview and Interact are apparently working as intended. Deploy to Custom, OK.
    • CryptoPizza: Compile, Deploy to Browser, Preview and Interact OK

[notes]

@donfrigo donfrigo merged commit 71525de into master Nov 8, 2019
@javier-tarazaga javier-tarazaga deleted the fix-custom-network-bug branch March 30, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants