Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File renaming should go though redux #278

Closed
ostap1010 opened this issue Dec 11, 2018 · 1 comment
Closed

File renaming should go though redux #278

ostap1010 opened this issue Dec 11, 2018 · 1 comment
Assignees
@ostap1010

Comments

@ostap1010
Copy link
Contributor

ostap1010 commented Dec 11, 2018 •
edited
Loading

Description

  • When renaming file in the file explorer - opened file name should be changed as well. This should be done though redux store.
  • Also refactor some pane components state to use redux. (Because it is overlapping with renaming functionality)

Expected result

Works as it is now, but using redux store

Actual result

Works well, but not utilizing redux
@ostap1010 ostap1010 self-assigned this Dec 11, 2018
ostap1010 pushed a commit to ostap1010/superblocks-lab that referenced this issue Dec 12, 2018
Store opened panes in the redux store (SuperblocksHQ#278)
17224cc
ostap1010 pushed a commit to ostap1010/superblocks-lab that referenced this issue Dec 12, 2018
File renaming should go though redux SuperblocksHQ#278
c262fff
ostap1010 pushed a commit to ostap1010/superblocks-lab that referenced this issue Dec 12, 2018
Refator panes-header to separate compoentn SuperblocksHQ#278
6610fae
ostap1010 pushed a commit to ostap1010/superblocks-lab that referenced this issue Dec 12, 2018
Save active pane state in redux store SuperblocksHQ#278
7357749
@ostap1010 ostap1010 mentioned this issue Dec 12, 2018
Merged
ostap1010 added a commit that referenced this issue Dec 12, 2018
@ostap1010
Merge pull request #281 from ostap1010/master
e5961c0 
Fixes for issue #278
@ostap1010
Copy link
Contributor Author

Fixed

@filippsen filippsen mentioned this issue Dec 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ostap1010 ostap1010

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ostap1010