Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial exclude optimizer implementation #69

Merged
merged 11 commits into from
Nov 28, 2024

Conversation

xiboon
Copy link
Contributor

@xiboon xiboon commented Oct 27, 2024

Closes #46 yay....!!!!

Copy link

pkg-pr-new bot commented Oct 27, 2024

Open in Stackblitz

npm i https://pkg.pr.new/tinyglobby@69

commit: 479f99d

@xiboon xiboon marked this pull request as ready for review October 29, 2024 17:01
@robertsLando
Copy link

I would also suggest to add a test that does some performance check and compare results with globby

@SuperchupuDev SuperchupuDev marked this pull request as draft November 26, 2024 21:38
@SuperchupuDev
Copy link
Owner

for anyone interested in helping, this PR makes vite tests fail, but we are struggling to debug it due to the message produced (and a lack of time). you can see the ci run on my test fork https://github.com/SuperchupuDev/vite

@xuanduc987
Copy link
Contributor

xuanduc987 commented Nov 28, 2024

After some debugging, seems like the problematic one was lone double star ** pattern, I tried to fix it with xiboon#1

@robertsLando
Copy link

@SuperchupuDev could you merge @xuanduc987 changes and retry vite tests?

@SuperchupuDev
Copy link
Owner

cc @xiboon

@SuperchupuDev
Copy link
Owner

After some debugging, seems like the problematic one was lone double star ** pattern, I tried to fix it with xiboon#1

merged, thanks :)
will rerun vite's tests

@SuperchupuDev
Copy link
Owner

vite tests pass :O

@SuperchupuDev
Copy link
Owner

testing in some more repos, 3 tests from @yao-pkg/pkg are failing, again with no clear error message 🫠 https://github.com/yao-pkg/pkg/actions/runs/12068434516/job/33653545386?pr=121

@xuanduc987
Copy link
Contributor

@SuperchupuDev Isn't the reason for the failing tests is this?
yao-pkg/pkg#121 (comment)
Revert the change to collect function would make it green I think.

@SuperchupuDev
Copy link
Owner

SuperchupuDev commented Nov 28, 2024

oh, right, thought i had reverted that... my bad

ci green again, thanks

This reverts commit 8c684ec.
@SuperchupuDev SuperchupuDev changed the title Implement more efficient excluding algorithm initial exclude optimizer implementation Nov 28, 2024
@SuperchupuDev SuperchupuDev marked this pull request as ready for review November 28, 2024 22:29
Copy link
Owner

@SuperchupuDev SuperchupuDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are some improvements that can be done (and i'll try to do before a new release), but it's good as an initial implementation. thanks everyone for the help! :)

@SuperchupuDev SuperchupuDev merged commit ee6e02b into SuperchupuDev:main Nov 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potentially the biggest performance improvement that can be done
4 participants