Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with query.hasOwnProperty described https://github.com/node… #2

Closed
wants to merge 1 commit into from

Conversation

vbuyakov
Copy link

@vbuyakov vbuyakov commented Sep 4, 2018

In this PR fix for error descibed bellow.
linked nodejs issue

lib/node_modules/homebridge-http-notification-server/notification-server.js:196

            if (password && (!query.hasOwnProperty("password") || query.password !== password)) {
                                    ^
TypeError: query.hasOwnProperty is not a function
    at Server.handleHTTPCall (/home/vik/.nvm/versions/node/v8.9.1/lib/node_modules/homebridge-http-notification-server/notification-server.js:196:37)
    at emitTwo (events.js:126:13)
    at Server.emit (events.js:214:7)
    at parserOnIncoming (_http_server.js:602:12)
    at HTTPParser.parserOnHeadersComplete (_http_common.js:117:23)

@Supereg
Copy link
Owner

Supereg commented Sep 6, 2018

Thanks for pointing me to this issue. I implemented the fix myself already and additionally fixed to other issues I discovered yesterday.
v1.0.4 is going live now containing three bug fixes.
Again, thanks for your work 👍

@Supereg Supereg closed this Sep 6, 2018
@vbuyakov vbuyakov deleted the bugfix/request_query_issue branch September 6, 2018 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants