🐛 Fix body padding issue when select dropdown in MUI #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for edspresso-develop ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
dkiatsongsak00
approved these changes
Mar 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Problem]
Material-UI adds padding to the body tag when select filter ( lessons & times )
[Cause]
This behavior is caused by the design decision of the MUI Select component. In the DOM structure generated by the MUI Select component, the input element created in the renderValue method of the Select component and the Menu component are at the same level.
[Fixed]
Chage MUI Select component to html select element.
[TODO]
Add more styling about select element.