Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #369 relative command path (New) #648

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

lukeweber
Copy link
Contributor

  1. Uses isabs() for program check which was mentioned here as a desired fix and makes sense.
  2. Inserts program directory into position 0 in path search for program, which is similar to how path search works in other programs when executing a command from a directory.
  3. Now has two tests for having the program in a custom path, and for having the program in the program directory.

Incorporates feedback from original pull:
#508

Resolves:
#369

I would update the docs. "If it is relative, the supervisord’s environment $PATH will be searched for the executable." => "If it is relative, the program's directory and supervisord’s environment $PATH will be searched for the executable."

@mnaberez
Copy link
Member

This is so close to #508 that I am going to close it as a duplicate with a link back here.

@lukeweber lukeweber changed the title Relative cmd Fix #369 relative command path (New) Aug 19, 2015
@mnaberez mnaberez reopened this Aug 19, 2015
@lukeweber
Copy link
Contributor Author

@mnaberez - As far as I know this patch is done.

@laoyur
Copy link

laoyur commented Jun 22, 2017

still no luck to get this merged after 2 years ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants