-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuration file to be specified via a environment variable #917
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't merge any new features that don't have tests. Please remove the unrelated gitignore changes.
|
Thanks, I've merged #919. |
@mnaberez got tests now and they pass in the CI. Please let me know if you need anything else! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll test this locally and if I don't find any issues, I'll merge it for the next feature release.
Thank you! :) |
@mnaberez any news on this? :) |
Hello, I came here searching for this. Any news on when it's planned to be merged/released? |
I'd have created this very pull request if this wasn't here already. What is the status of this, what is missing (if anything) before this can be merged? |
I reviewed it again and it looks fine to me. I intend to include it in the next release. |
Hi, I'd love to see this feature as well. Did anything change since your last review, what is required for this to be merged? |
We are still interested as well. |
Fixes #742
This PR enables the configuration file to be specified in the
$SUPERVISOR_CONFIG
environment variable. Refer to the issue for further discussion.