Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/download queue and cleanup visuals overall #202

Merged

Conversation

martinek
Copy link
Contributor

This PR started as download queue update, but ended up with some more cleanup.

I have moved all the app contexts and stuff to separate component so that routes do not end up intended 100 spaces. The new component is called AppContext. I have also moved theme creation to separate file and added new custom color with values for cases when solid color is needed, that is different then basic background color.

With new custom color, I have replaced usage of theme.palette.mode === 'dark' for determining background color. This fixed background color of some components that were currently incorrect in light mode. I have also used focused background color instead of some custom colors.

Some of the changes (I might have missed some for screenshots):

Reader navbar background (divider was changed from hr to Divider)
Tachidesk_and_Tachidesk

Hover state
Tachidesk_and_Tachidesk

Extensions list
Tachidesk_and_Tachidesk_and_Tachidesk

I have changed different clickable element styles for cards with CardActionArea to unify looks. Another benefit is that all the items are now links, so things like middle mouse click will work as intended.

Library
Tachidesk_and_Tachidesk_and_Tachidesk

Tachidesk_and_Tachidesk

Sources

Tachidesk_and_Tachidesk_and_Tachidesk

Tachidesk_and_Tachidesk

Search All
Tachidesk_and_Tachidesk

Updates (new download progress is visible, more below)
Tachidesk_and_Tachidesk

I have also fixed manga card title color to work correctly in light theme comfortable layout

Tachidesk_and_Tachidesk_and_Tachidesk

Download queue was refactored and cleaned up. It now also uses Cards with CardActiveArea for items. New DownloadStateIndicator was added to better indicate download state and progress. It was also used in Updates screen (see above) and ChapterList in Manga screen.

Tachidesk_and_Tachidesk

(chapter list filter icon was also changed back to warn color instead of badge when filtering is active)
Tachidesk_and_Tachidesk

This doesn't fix anything, it is just cleanup and code improvement.

@AriaMoradi AriaMoradi merged commit 8dfc89e into Suwayomi:master Nov 26, 2022
@martinek martinek deleted the refactor/download-queue-and-visuals branch November 26, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants