-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send complete event #29
Conversation
I think this would be a really great improvement, so thank you! π― What I'm however a bit worried about is backwards compatibility. There are users that leverage the |
I liked the idea! Updated the PR using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it and we're almost there. I requested a couple of minor changes and then we're good to go. π
src/handlers/push.ts
Outdated
...data, | ||
token: token.data.token | ||
data: context.payload |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think naming is a bit confusing because we use the spread operator on data
on line 67. I wouldn't use a variable and a object property within the same context if they have a different value. Could we either rename the object property or otherwise the data variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed it to event
. I thought about origin_event
or original_event
, but I think that in the context of a repository dispatch just event
shouldn't be misleading.
Co-authored-by: Sebass van Boxel <hello@svboxel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π’
Release with 1.3.0. |
β Purpose
Send complete github event in
client_payload.data
at createEventDispatch.π Use cases
I'd like to run sonarscanner to check for code health globally in the organization. For this I need metadata such as the PR number. I thought it would be best to send everything since I sure I'll have a use case for other infos in the future.