Skip to content

Commit

Permalink
patches/luci: replace patches for LuCI PR 2637 with recent version
Browse files Browse the repository at this point in the history
The PR openwrt/luci#2637 has been completely rewritten, so update to it.
  • Loading branch information
SvenRoederer committed May 9, 2021
1 parent c20f50d commit 2498da7
Show file tree
Hide file tree
Showing 3 changed files with 97 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
From: Sven Roederer <devel-sven@geroedel.de>
Date: Sat, 17 Apr 2021 17:37:08 +0200
Subject: luci.mk: add URL and MAINTAINER fields to package-definitions

Add the LUCI_URL and LUCI_MAINTAINER variables to pass them to the buildpackage
defines. Give them some sane defaults and allow overwritting by the individual
package.

Signed-off-by: Sven Roederer <devel-sven@geroedel.de>

diff --git a/luci.mk b/luci.mk
index 65bcf15a57339ab35f8a70732fbe0aad353872c5..cb53aa2bbd7715ceb38dd7180f7979b76c10cc55 100644
--- a/luci.mk
+++ b/luci.mk
@@ -12,6 +12,8 @@ LUCI_DEFAULTS:=$(notdir $(wildcard ${CURDIR}/root/etc/uci-defaults/*))
LUCI_PKGARCH?=$(if $(realpath src/Makefile),,all)
LUCI_SECTION?=luci
LUCI_CATEGORY?=LuCI
+LUCI_URL?=https://github.com/openwrt/luci
+LUCI_MAINTAINER?=OpenWrt LuCI community

# Language code titles
LUCI_LANG.ar=العربية (Arabic)
@@ -130,6 +132,8 @@ define Package/$(PKG_NAME)
VERSION:=$(if $(PKG_VERSION),$(PKG_VERSION),$(PKG_SRC_VERSION))
$(if $(LUCI_EXTRA_DEPENDS),EXTRA_DEPENDS:=$(LUCI_EXTRA_DEPENDS))
$(if $(LUCI_PKGARCH),PKGARCH:=$(LUCI_PKGARCH))
+ URL:=$(LUCI_URL)
+ MAINTAINER:=$(LUCI_MAINTAINER)
endef

ifneq ($(LUCI_DESCRIPTION),)
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
From: Sven Roederer <devel-sven@geroedel.de>
Date: Sat, 17 Apr 2021 22:38:24 +0200
Subject: luci.mk: add PKG_PROVIDES make-macro to set package/provides option

Add PKG_PROVIDES macro to be passed down to buildpackage defines as PROVIDES variable.

Signed-off-by: Sven Roederer <devel-sven@geroedel.de>

diff --git a/luci.mk b/luci.mk
index cb53aa2bbd7715ceb38dd7180f7979b76c10cc55..319551789f221630c574c190babab05cfe8a040c 100644
--- a/luci.mk
+++ b/luci.mk
@@ -132,6 +132,7 @@ define Package/$(PKG_NAME)
VERSION:=$(if $(PKG_VERSION),$(PKG_VERSION),$(PKG_SRC_VERSION))
$(if $(LUCI_EXTRA_DEPENDS),EXTRA_DEPENDS:=$(LUCI_EXTRA_DEPENDS))
$(if $(LUCI_PKGARCH),PKGARCH:=$(LUCI_PKGARCH))
+ $(if $(PKG_PROVIDES),PROVIDES:=$(PKG_PROVIDES))
URL:=$(LUCI_URL)
MAINTAINER:=$(LUCI_MAINTAINER)
endef
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
From: Sven Roederer <devel-sven@geroedel.de>
Date: Thu, 22 Apr 2021 22:35:58 +0200
Subject: luci.mk: make SUBMENU package define customizable and optional

When including luci.mk in external repos it's sometimes usefull to not use
the default LuCI-submenu hierarchy.
This change defines the LUCI_SUBMENU_FORCED variable which completely overrides
the default submenu of the LuCI config-section. When LUCI_SUBMENU_FORCED is not
defined, the default submenu derrived from LUCI_TYPE or "Application" fallback
is used.
Defining LUCI_SUBMENU_FORCED in the package Makefile will just use this value.
Setting it to "none" will not define a submenu at all.
Together with LUCI_SECTION and LUCI_CATEGORY menu items can now created at any
place in the menu structure.

Signed-off-by: Sven Roederer <devel-sven@geroedel.de>

diff --git a/luci.mk b/luci.mk
index 319551789f221630c574c190babab05cfe8a040c..636cf316ec3fdaf154685750760210a447e46969 100644
--- a/luci.mk
+++ b/luci.mk
@@ -123,10 +123,22 @@ PKG_GITBRANCH?=$(if $(DUMP),x,$(strip $(shell \

include $(INCLUDE_DIR)/package.mk

+# LUCI_SUBMENU: the submenu-item below the LuCI top-level menu inside OpoenWrt menuconfig
+# usually one of the LUCI_MENU.* definitions
+# LUCI_SUBMENU_DEFAULT: the regular SUBMENU defined by LUCI_TYPE or derrived from the packagename
+# LUCI_SUBMENU_FORCED: manually forced value SUBMENU to set to by explicit definiton
+# can be any string, "none" disables the creation of a submenu
+# most usefull in combination with LUCI_CATEGORY, to make the package appear
+# anywhere in the menu structure
+LUCI_SUBMENU_DEFAULT=$(if $(LUCI_MENU.$(LUCI_TYPE)),$(LUCI_MENU.$(LUCI_TYPE)),$(LUCI_MENU.app))
+LUCI_SUBMENU=$(if $(LUCI_SUBMENU_FORCED),$(LUCI_SUBMENU_FORCED),$(LUCI_SUBMENU_DEFAULT))
+
define Package/$(PKG_NAME)
SECTION:=$(LUCI_SECTION)
CATEGORY:=$(LUCI_CATEGORY)
- SUBMENU:=$(if $(LUCI_MENU.$(LUCI_TYPE)),$(LUCI_MENU.$(LUCI_TYPE)),$(LUCI_MENU.app))
+ifneq ($(LUCI_SUBMENU),none)
+ SUBMENU:=$(LUCI_SUBMENU)
+endif
TITLE:=$(if $(LUCI_TITLE),$(LUCI_TITLE),LuCI $(LUCI_NAME) $(LUCI_TYPE))
DEPENDS:=$(LUCI_DEPENDS)
VERSION:=$(if $(PKG_VERSION),$(PKG_VERSION),$(PKG_SRC_VERSION))

0 comments on commit 2498da7

Please sign in to comment.