Fix request path and query params' example support. #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The adoc output of a path' example always use the default value.For
example in the unit test:
* pets/{petId} use the path params `petId` with example 30, but the
output adoc rendered pets/0 (0 is the default value of int param)
* pets/{findByTags} use the query params `tags` with example adorable,
but the output adoc rendered "tags":"string" ("string" is the default
value of string param)
It should use the "x-example" of the swagger(also the method `example()`
of the swagger-core jar.
This is the first commit to fix this problem, which add the
unit test for it.
|
@RobWin codacy shows it had two duplication in unit test. It's OK? |
|
Yes, that's fine for me. |
|
Yeah~ It's done. @RobWin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The adoc output of a path' example always use the default value.For
example in the unit test:
petIdwith example 30, but theoutput adoc rendered pets/0 (0 is the default value of int param)
tagswith example adorable,but the output adoc rendered "tags":"string" ("string" is the default
value of string param)
It should use the "x-example" of the swagger(also the method
example()of the swagger-core jar.
This is the first commit to fix this problem, which add the
unit test for it.