Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤔 [QUESTION] Table Components Optimization #88

Closed
Feudalman opened this issue Dec 26, 2023 · 2 comments · Fixed by #106
Closed

🤔 [QUESTION] Table Components Optimization #88

Feudalman opened this issue Dec 26, 2023 · 2 comments · Fixed by #106
Assignees
Labels
💪 enhancement New feature or request 🙋 help wanted Extra attention is needed
Milestone

Comments

@Feudalman
Copy link
Member

Feudalman commented Dec 26, 2023

🤔 Question description

There are some optimizations can be made for the table component SLTable.vue

Part 1

These are something about the code implementation methods.

  1. Tabe cell's width resizating
  2. Our custom colors definition
  3. Size calculation in JavaScript —— mouse events while dragging resizing line

Part 2

These are something more difficult and require some effort

  1. Dynamically load table content
  2. Organizational format of table data
  3. Api that we can use

🧑‍💻 Expected result

  1. More elegant code
  2. A smoother experience

🚑 Any additional

  • SwanLab Version: v0.1.1
@Feudalman Feudalman added 💪 enhancement New feature or request 🙋 help wanted Extra attention is needed labels Dec 26, 2023
@Feudalman Feudalman self-assigned this Dec 26, 2023
@Feudalman
Copy link
Member Author

About Part 2 - 1,we simplify the hash function in PR #87

@Feudalman Feudalman reopened this Dec 26, 2023
@Feudalman
Copy link
Member Author

Feudalman commented Dec 26, 2023

For some repetitive code, we must think about how to use component encapsulation, and how to organize the common state.

@SAKURA-CAT SAKURA-CAT added this to the V0.1.2 milestone Dec 28, 2023
SAKURA-CAT added a commit that referenced this issue Dec 30, 2023
* fix #88

---------

Co-authored-by: KAAANG <cunykang@gmail.com>
Feudalman added a commit that referenced this issue Dec 30, 2023
commit 300178b
Author: Zirui Cai <74649535+Feudalman@users.noreply.github.com>
Date:   Sun Dec 31 00:08:21 2023 +0800

    feat: stop experiment on dashboard (#108)

    * fix #107

    * fix #36

commit 71630bb
Author: Zirui Cai <74649535+Feudalman@users.noreply.github.com>
Date:   Sun Dec 31 00:06:24 2023 +0800

    Refactor/sl table (#106)

    * fix #88

    ---------

    Co-authored-by: KAAANG <cunykang@gmail.com>
Feudalman added a commit that referenced this issue Jan 2, 2024
commit 300178b
Author: Zirui Cai <74649535+Feudalman@users.noreply.github.com>
Date:   Sun Dec 31 00:08:21 2023 +0800

    feat: stop experiment on dashboard (#108)

    * fix #107

    * fix #36

commit 71630bb
Author: Zirui Cai <74649535+Feudalman@users.noreply.github.com>
Date:   Sun Dec 31 00:06:24 2023 +0800

    Refactor/sl table (#106)

    * fix #88

    ---------

    Co-authored-by: KAAANG <cunykang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request 🙋 help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants