Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/object3d chart #382

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Feat/object3d chart #382

merged 4 commits into from
Mar 4, 2024

Conversation

Nexisato
Copy link
Collaborator

@Nexisato Nexisato commented Mar 2, 2024

Add Object3D class,

  • Support data_or_path parameters:
    • str: 3d model files end with: (obj, gltf, glb, babylon, stl, pts.json)
    • bytes.IO: write with pts.json format
    • numpy.array: write with pts.json format,
      array shape requirements:
      (N, 3) : N * (x, y, z) coordinates
      (N, 4) : N * (x, y, z, c) coordinates, where c in range [1, 14]
      (N, 6) : N * (x, y, z, r, g, b) coordinates

Closes: #322

@Nexisato Nexisato requested review from Zeyi-Lin and SAKURA-CAT March 2, 2024 12:19
@Zeyi-Lin Zeyi-Lin added this to the v0.2.2 milestone Mar 3, 2024
SAKURA-CAT
SAKURA-CAT requested changes Mar 3, 2024
View reviewed changes
test/create_experiment.py Outdated Show resolved Hide resolved
@SAKURA-CAT SAKURA-CAT merged commit f0f52d8 into main Mar 4, 2024
@SAKURA-CAT SAKURA-CAT deleted the feat/object3d-chart branch March 4, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SAKURA-CAT SAKURA-CAT SAKURA-CAT approved these changes

@Zeyi-Lin Zeyi-Lin Zeyi-Lin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2.2
Development

Successfully merging this pull request may close these issues.

[FEATURE] class Object3D
3 participants
@Nexisato @Zeyi-Lin @SAKURA-CAT