Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: hardware task and model #749

Merged
merged 7 commits into from
Dec 6, 2024
Merged

refactor: hardware task and model #749

merged 7 commits into from
Dec 6, 2024

Conversation

SAKURA-CAT
Copy link
Contributor

@SAKURA-CAT SAKURA-CAT commented Dec 6, 2024 •
edited
Loading

Description

对 #748 的部分逻辑做了修改：

  • 将硬件监控定时任务挂载在了swanlab run类上，因为它本质上是run的活动，而非cloud的活动——但是只有在cloud模式上会开启此任务
  • 本地数据保存时屏蔽硬件监控产出的信息
  • 修改了部分工具函数的位置
  • 更新了这部分的文档
  • 为了在云端版适配往期没有硬件监控信息的实验，对实验元信息增加了标识位
  • 删除了实验元信息-第三方信息中关于swanlab的信息，这部分信息为无效信息（但是webhook依旧会携带）。

@SAKURA-CAT SAKURA-CAT added the 💪 enhancement New feature or request label Dec 6, 2024
@SAKURA-CAT SAKURA-CAT requested a review from Zeyi-Lin December 6, 2024 06:48
@SAKURA-CAT SAKURA-CAT self-assigned this Dec 6, 2024
@SAKURA-CAT SAKURA-CAT merged commit 8bc918a into main Dec 6, 2024
5 checks passed
@SAKURA-CAT SAKURA-CAT deleted the feat/hardware-monitor branch December 6, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeyi-Lin Zeyi-Lin Zeyi-Lin approved these changes

Assignees

@SAKURA-CAT SAKURA-CAT

Labels
💪 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SAKURA-CAT @Zeyi-Lin