Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wandb conver #853

Merged
merged 2 commits into from
Mar 4, 2025
Merged

fix: wandb conver #853

merged 2 commits into from
Mar 4, 2025

Conversation

Zeyi-Lin
Copy link
Member

@Zeyi-Lin Zeyi-Lin commented Mar 4, 2025

Description

  1. Adapt to the API format of the new wandb version
  2. Might solve part of issue [BUG] AttributeError in conver the wandb log into swanlab log #852 :)

This pull request includes changes to the parse_wandb_logs method in the swanlab/converter/wb/wb_converter.py file. The updates focus on improving error handling and enhancing the processing of Wandb logs. The most important changes are:

Error handling improvements:

  • Added a check to ensure pandas is installed when processing Wandb logs, raising a TypeError if it is missing.
  • Wrapped the metadata extraction in a try-except block to handle potential errors gracefully.

Enhancements to Wandb log processing:

  • Modified the assignment of the cloud parameter to simplify the configuration.
  • Updated the logic to check if the history is a DataFrame and extract keys accordingly, improving compatibility with different data formats.

@Zeyi-Lin Zeyi-Lin requested a review from SAKURA-CAT March 4, 2025 10:17
@Zeyi-Lin Zeyi-Lin self-assigned this Mar 4, 2025
@Zeyi-Lin Zeyi-Lin added the 🐛 bug Something isn't working label Mar 4, 2025
@SAKURA-CAT SAKURA-CAT merged commit 3153915 into main Mar 4, 2025
5 checks passed
@SAKURA-CAT SAKURA-CAT deleted the fix/wandb-convert-metadata branch March 4, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants