Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(guacamole-chart): Add NetworkPolicy manifests to defend pods #10

Draft
wants to merge 45 commits into
base: main
Choose a base branch
from

Conversation

rdash99
Copy link
Contributor

@rdash99 rdash99 commented Mar 21, 2024

No description provided.

@rdash99 rdash99 added enhancement New feature or request helm labels Mar 21, 2024
@rdash99 rdash99 self-assigned this Mar 21, 2024
@rdash99 rdash99 linked an issue Mar 21, 2024 that may be closed by this pull request
@JossWhittle JossWhittle changed the title Feat: Add NetworkPolicy manifests to defend pods feat(guacamole-chart): Add NetworkPolicy manifests to defend pods Mar 21, 2024
@JossWhittle JossWhittle force-pushed the feat/add-networkpolicy-manifests-to-defend-pods branch from 7c7ed17 to 7b2b569 Compare March 21, 2024 16:08
@JossWhittle JossWhittle reopened this Mar 21, 2024
@JossWhittle JossWhittle closed this Apr 4, 2024
@JossWhittle JossWhittle reopened this Apr 4, 2024
…-to-defend-pods' into feat/add-networkpolicy-manifests-to-defend-pods
@JossWhittle JossWhittle closed this Apr 4, 2024
@JossWhittle JossWhittle reopened this Apr 4, 2024
@rdash99 rdash99 marked this pull request as ready for review April 4, 2024 20:31
@rdash99 rdash99 requested a review from JossWhittle April 4, 2024 20:31
Copy link
Member

@JossWhittle JossWhittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add fields to the values.yaml to conditionally enable / disable creating each of the network policies.

Each will need values.yaml fields for extraIngress: [] and extraEgress: [] which will be appended to the list of rules you are putting in the NetworkPolicy manifests.

Something like this pattern maybe?

controller:
  networkPolicy:
    enabled: true
    extraIngress: []
    extraEgress: 
      - podSelector:
          matchLabels:
            foo: bar

charts/guacamole/templates/web/web-network.yaml Outdated Show resolved Hide resolved
charts/guacamole/templates/guacd/guacd-network.yaml Outdated Show resolved Hide resolved
charts/guacamole/templates/database/database-network.yaml Outdated Show resolved Hide resolved
charts/guacamole/templates/web/web-network.yaml Outdated Show resolved Hide resolved
@rdash99 rdash99 marked this pull request as draft July 4, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add NetworkPolicy manifests to defend pods
2 participants