-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(guacamole-chart): Add NetworkPolicy manifests to defend pods #10
Draft
rdash99
wants to merge
45
commits into
main
Choose a base branch
from
feat/add-networkpolicy-manifests-to-defend-pods
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JossWhittle
changed the title
Feat: Add NetworkPolicy manifests to defend pods
feat(guacamole-chart): Add NetworkPolicy manifests to defend pods
Mar 21, 2024
JossWhittle
force-pushed
the
feat/add-networkpolicy-manifests-to-defend-pods
branch
from
March 21, 2024 16:08
7c7ed17
to
7b2b569
Compare
JossWhittle
reviewed
Mar 21, 2024
This reverts commit 3d1153c.
…-to-defend-pods' into feat/add-networkpolicy-manifests-to-defend-pods
JossWhittle
requested changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add fields to the values.yaml
to conditionally enable / disable creating each of the network policies.
Each will need values.yaml
fields for extraIngress: []
and extraEgress: []
which will be appended to the list of rules you are putting in the NetworkPolicy manifests.
Something like this pattern maybe?
controller:
networkPolicy:
enabled: true
extraIngress: []
extraEgress:
- podSelector:
matchLabels:
foo: bar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.