fix: export both cjs and esm types #212
Conversation
| output: [{ file: pkg.types, format: "es" }], | ||
| output: [ | ||
| { file: pkg.exports.types.import, format: "es" }, | ||
| { file: pkg.exports.types.require, format: "commonjs", exports: "named" }, |
There was a problem hiding this comment.
this won’t really have any effect, as we override these output options; and exclusively only generate ES exports.
There was a problem hiding this comment.
We need to generate both a .d.mts and a .d.cts file. These two files would be identical but they need to be different files.
I'll leave it to you to figure what the best way to do that is. Whether it be to use this PR as is, use format: "es" for both outputs or just generate one then copy-paste it.
There was a problem hiding this comment.
Could even just shorten it to:
output: [{ file: pkg.exports.types.import }, { file: pkg.exports.types.require }]There was a problem hiding this comment.
I think the rollup typings require you to define at least one format. I can take a look on the weekend again, I was distracted with other matters these days.
|
I experience this problem too. Do you need help with the PR? |
|
#271 did just this slightly differently |
Fixes #210
https://github.com/microsoft/TypeScript/issues/49299#issuecomment-1140421993#212