Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX-914: Remove lockfile #268

Merged
merged 1 commit into from
Nov 5, 2021
Merged

DX-914: Remove lockfile #268

merged 1 commit into from
Nov 5, 2021

Conversation

asbjornu
Copy link
Contributor

@asbjornu asbjornu commented Nov 5, 2021

Delete Gemfile.lock and specify versions in the Gemfile instead. This will hopefully make it easier to consume the Docker image.

@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #268 (0ba6e31) into main (8859105) will not change coverage.
The diff coverage is n/a.

❗ Current head 0ba6e31 differs from pull request most recent head d684c18. Consider uploading reports for the commit d684c18 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #268   +/-   ##
=======================================
  Coverage   94.64%   94.64%           
=======================================
  Files          28       28           
  Lines         784      784           
=======================================
  Hits          742      742           
  Misses         42       42           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8859105...d684c18. Read the comment docs.

@asbjornu asbjornu force-pushed the feature/dx-914_gemspec branch from 5e9016e to 90af2f7 Compare November 5, 2021 21:23
@asbjornu asbjornu changed the title DX-914: Add gemspec DX-914: Remove lockfile Nov 5, 2021
Delete Gemfile.lock and specify versions in the Gemfile instead.
@asbjornu asbjornu force-pushed the feature/dx-914_gemspec branch from 90af2f7 to d684c18 Compare November 5, 2021 21:28
@asbjornu asbjornu marked this pull request as ready for review November 5, 2021 22:37
@asbjornu asbjornu merged commit 44fab91 into main Nov 5, 2021
@asbjornu asbjornu deleted the feature/dx-914_gemspec branch November 5, 2021 22:37
@mergify
Copy link
Contributor

mergify bot commented Nov 5, 2021

Thank you @asbjornu for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant