Fix HTMLProofer authentication #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asbjornu
force-pushed
the
feature/dx-1096_html_proofer_auth
branch
from
ea22f9a to
3faf709
Compare
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
+ Coverage 91.70% 91.81% +0.10%
==========================================
Files 21 21
Lines 603 611 +8
==========================================
+ Hits 553 561 +8
Misses 50 50
Continue to review full report at Codecov.
|
asbjornu
force-pushed
the
feature/dx-1096_html_proofer_auth
branch
2 times, most recently
from
a9939e8 to
5fcbb25
Compare
asbjornu
force-pushed
the
feature/dx-1096_html_proofer_auth
branch
from
e037e40 to
e460f2e
Compare
Install the concurrent-ruby Gem and configure the :parallel option in HTMLProofer.
Bump html-proofer from 3.15.3 to 3.16.0 to get #before_request, enabling us to send Authorization header to github domains.
asbjornu
force-pushed
the
feature/dx-1096_html_proofer_auth
branch
from
e460f2e to
a4b732e
Compare
NullableInt
pushed a commit
that referenced
this pull request
Sep 16, 2020
…auth Fix HTMLProofer authentication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hopefully fixes HTMLProofer authentication. As per gjtorikian/html-proofer#86 (comment) it's a bit unclear just how HTMLProofer expects the
:domain_authto be set, so this PR will explore ways to do it correctly.