Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Git branch to Jekyll configuration #91

Merged
merged 37 commits into from
Dec 10, 2020

Conversation

asbjornu
Copy link
Contributor

@asbjornu asbjornu commented Dec 4, 2020

This PR adds the Git branch and repository URL to the Jekyll configuration by introducing a GitMetadataProvider that encapsulate the logic that is currently in the Developer Portal's Rakefile.

@asbjornu asbjornu requested a review from NullableInt December 4, 2020 20:11
@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #91 (16bd398) into master (a679fa7) will increase coverage by 3.30%.
The diff coverage is 91.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   91.83%   95.13%   +3.30%     
==========================================
  Files          21       28       +7     
  Lines         612      760     +148     
==========================================
+ Hits          562      723     +161     
+ Misses         50       37      -13     
Impacted Files Coverage Δ
.docker/entrypoint/lib/commander.rb 86.11% <66.66%> (+0.19%) ⬆️
.docker/entrypoint/lib/entrypoint.rb 90.90% <66.66%> (+29.61%) ⬆️
.docker/entrypoint/lib/git_metadata_provider.rb 72.72% <72.72%> (ø)
.docker/entrypoint/lib/gemfile_generator_exec.rb 93.93% <85.71%> (+36.36%) ⬆️
.docker/entrypoint/lib/gemfile_generator.rb 92.06% <87.50%> (+4.56%) ⬆️
.docker/entrypoint/lib/gemfile_differ.rb 98.07% <90.90%> (ø)
.docker/entrypoint/lib/argument_parser.rb 100.00% <100.00%> (ø)
.docker/entrypoint/lib/argument_string_builder.rb 100.00% <100.00%> (ø)
.docker/entrypoint/lib/arguments.rb 100.00% <100.00%> (ø)
...docker/entrypoint/lib/commands/default_commands.rb 94.11% <100.00%> (-0.89%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a679fa7...16bd398. Read the comment docs.

@asbjornu asbjornu force-pushed the feature/dx-1446_branch_finder branch 3 times, most recently from a8134e5 to 3efd7ed Compare December 5, 2020 19:17
@asbjornu asbjornu changed the title Add Git branch and repository URL to Jekyll configuration Add Git branch to Jekyll configuration Dec 5, 2020
Copy link
Contributor

@NullableInt NullableInt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few questions 😃

.docker/entrypoint/lib/gemfile_generator_exec.rb Outdated Show resolved Hide resolved
.docker/entrypoint/spec/gemfile_generator_exec_spec.rb Outdated Show resolved Hide resolved
@asbjornu asbjornu force-pushed the feature/dx-1446_branch_finder branch 2 times, most recently from ab1ecf5 to a23c51b Compare December 8, 2020 14:13
@asbjornu asbjornu requested a review from NullableInt December 8, 2020 21:56
@asbjornu asbjornu force-pushed the feature/dx-1446_branch_finder branch from 92ef7c7 to 64283db Compare December 8, 2020 22:02
Make arguments assertion more precise by asserting type instead of just not nil.
- Extract logging to a new `ConsoleLogger` class.
- Extract argument parsing to a new `Options` class.

Also use the two new classes throughout the path of code that needs to be dependency-free because it executes before `bundle install` is run.
@asbjornu asbjornu force-pushed the feature/dx-1446_branch_finder branch from 23d6329 to 16bd398 Compare December 9, 2020 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants