-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Git branch to Jekyll configuration #91
Conversation
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
==========================================
+ Coverage 91.83% 95.13% +3.30%
==========================================
Files 21 28 +7
Lines 612 760 +148
==========================================
+ Hits 562 723 +161
+ Misses 50 37 -13
Continue to review full report at Codecov.
|
a8134e5
to
3efd7ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few questions 😃
ab1ecf5
to
a23c51b
Compare
92ef7c7
to
64283db
Compare
Add GitMetadataProvider to expose the current Git branch and repository URL and injecting it into the Jekyll configuration.
Make arguments assertion more precise by asserting type instead of just not nil.
- Extract logging to a new `ConsoleLogger` class. - Extract argument parsing to a new `Options` class. Also use the two new classes throughout the path of code that needs to be dependency-free because it executes before `bundle install` is run.
23d6329
to
16bd398
Compare
This PR adds the Git branch and repository URL to the Jekyll configuration by introducing a
GitMetadataProvider
that encapsulate the logic that is currently in the Developer Portal'sRakefile
.