Rebase onto apple/swift master #12
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modocache
force-pushed
the
swiftanrdoid-master-rebase
branch
2 times, most recently
from
603e38d to
06eff68
Compare
|
I've confirmed that this works. @zhuowei, mind if I force-push to |
modocache
force-pushed
the
swiftanrdoid-master-rebase
branch
from
06eff68 to
ea62f3c
Compare
modocache
changed the title
|
Rebased onto f82389a. |
…available on Android
…compile job pools from LLVM's cmake list, force -j1 and split dwarfs when compiling
…m compiler_rt, hardcode path to libicu for now
…op linker from complaining
….ld for Android target Hello world works now!
… Swift default linker flags, attempt at copying libicu libraries automatically (doesn't work)
the dynamic linker doesn't understand them and spams warnings.
…ers but is available on all versions so far)
modocache
force-pushed
the
swiftanrdoid-master-rebase
branch
from
ea62f3c to
f88771a
Compare
|
if it can produce a working executable, then of course you can force-push |
|
@zhuowei Excellent! I'll do so in the next few hours. |
|
Done! Be sure to pull before doing any more work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #11, but instead of merging
master, this is rebased on top of it.@zhuowei: I'm in the process of testing this rebase. If I can confirm that
swiftc-android hello.swift && swift-android-push hellowork, would you mind if I force-pushed this to SwiftAndroidmaster?