Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags & Filters documentation #12

Merged
merged 8 commits into from
Apr 30, 2017
Merged

Tags & Filters documentation #12

merged 8 commits into from
Apr 30, 2017

Conversation

AliSoftware
Copy link
Contributor

Work in Progress

AliSoftware added a commit that referenced this pull request Jan 22, 2017
@djbe djbe force-pushed the feature/documentation branch from 9e4e8d2 to 4803100 Compare January 28, 2017 14:57
djbe pushed a commit that referenced this pull request Jan 28, 2017
@djbe djbe force-pushed the feature/documentation branch from 4803100 to b6e83a9 Compare January 28, 2017 21:37
djbe pushed a commit that referenced this pull request Jan 28, 2017
@djbe djbe force-pushed the feature/documentation branch from b6e83a9 to 9aff9f3 Compare January 30, 2017 17:15
djbe pushed a commit that referenced this pull request Jan 30, 2017
@AliSoftware AliSoftware force-pushed the feature/documentation branch from 9aff9f3 to 1c1158e Compare February 19, 2017 02:32
AliSoftware added a commit that referenced this pull request Feb 19, 2017
@djbe djbe force-pushed the feature/documentation branch from 1c1158e to 3f83fb2 Compare March 4, 2017 19:51
djbe pushed a commit that referenced this pull request Mar 4, 2017
@djbe djbe force-pushed the feature/documentation branch from cbd0d88 to 21575ee Compare March 10, 2017 21:23
djbe pushed a commit that referenced this pull request Mar 10, 2017
@djbe djbe mentioned this pull request Apr 2, 2017
18 tasks
@djbe djbe force-pushed the feature/documentation branch from 5a897c6 to 33aa332 Compare April 24, 2017 17:27
djbe pushed a commit that referenced this pull request Apr 24, 2017
@djbe djbe force-pushed the feature/documentation branch from 33aa332 to 4f988ba Compare April 26, 2017 13:45
@djbe djbe removed the status: WIP label Apr 26, 2017
@djbe djbe mentioned this pull request Apr 28, 2017
2 tasks
## Filter: "hexToInt"

Accepts a string with a number in hexadecimal format, and converts it into an integer number.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add examples here same as for other filters?

| Tag Name | `call` |
| End Tag | N/A |
| Rendering | Immediately; output is the rendering of the called macro block |
| Example | `{% call myBlock "Dave" %}` |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It reads strange I think to have the example here before the table explaining the parameters? Maybe move those examples after the second table in a simple paragraph?

@AliSoftware AliSoftware merged commit 02169c3 into master Apr 30, 2017
@AliSoftware AliSoftware deleted the feature/documentation branch April 30, 2017 12:02
@djbe djbe mentioned this pull request May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants