SwiftLint 0.27 #96
Merged
SwiftLint 0.27 #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #95, so merge that first. ✅
This simply updates SwiftLint and fixes some warnings that are triggered in combination with Xcode 10. I've also enabled some more rules while I was it, nothing with much impact, but good to have.
I'd love to enable function_default_parameter_at_end, but that isn't an option with https://github.com/SwiftGen/StencilSwiftKit/blob/master/Sources/Filters.swift#L92. It'd be a breaking change to move those parameters, and we can't add an alias (while deprecating the current signature) because it confuses Swift.