-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
…enerate Info.plist content
Mmmmh tests pass locally on my machine, not sure why they don't pass the CI… will have to investigate later (I didn't see I wasn't logged in at first and thus didn't see the artefacts, which was a bit puzzling… time to 💤 I guess) |
Is it possible for a font to be in a subfolder? (and not just the root of the bundle) If so, is it a use case we want to cover? Edit: never mind, too early in the morning. Just re-read the implementation and noticed that |
Seeing the diff on github, your templates commit (submodule) also seems to have changes for storyboards, but looking at the diff for the templates PR, that isn't the case... weird stuff 😆 |
Submodules joy I guess |
Ah, I think #27 and #30 forgot to update the submodules on SwiftGenKit? Because with this commit I've moved the submodule from f963082efbada6cce373aeb0b58f6905d6f24451 (HEAD) to 0171473e1be23304caa3aa884082b7b3f2d39dc3, but template's masters 2 commits after f963082efbada6cce373aeb0b58f6905d6f24451 . So when you're in SwiftGenKit's master, its submodules doesn't point to templates' master, that's where the divergence comes from I think. |
Huh, weird that could happen. Will have to see if we can verify this in |
"name": font.postScriptName, | ||
"path": font.filePath, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to add this new variable to the context docs.
LGTM, I'll update #24 to match this. |
Btw, don't forget (as I did) to update this PR to point to templates master after SwiftGen/templates#37 is merged. |
Haha good point! 😉 |
So that we can later add templates to generate th
Info.plist
'sUIAppFonts
key contentSee also SwiftGen/templates#37