This repository has been archived by the owner on Sep 6, 2018. It is now read-only.
Swift 4 templates #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djbe
force-pushed
the
feature/swift4-templates
branch
from
7fa5381 to
6ac0a46
Compare
AliSoftware
approved these changes
Aug 13, 2017
There was a problem hiding this comment.
LGTM.
We could imagine still supporting Xcode 8.3 and emit a warning when running Swift 4 tests that they are skipped wth Xcode 8.3 (wrapping them in #if swift(>=4.0) etc). But I don't think it's worth it, as we're all gonna switch to Xcode 9 once it's out of beta anyway, so requiring it even while it's still in beta isn't a big requirement and maintaining Xcode 8.3 support while we want to support Swift 4 anyway won't be worth the maintenance hassle.
djbe
force-pushed
the
feature/swift4-templates
branch
from
1cf2cbc to
b020830
Compare
djbe
force-pushed
the
feature/swift4-templates
branch
from
b020830 to
8a524ca
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63.
Built on top of #66, so will need a rebase once that is merged.
To discuss: how should we handle the xcode version? Just increase it to 9 and expect SwiftGen devs to have it?