Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated to latest swift (3) #76

Merged
merged 1 commit into from
Aug 18, 2016
Merged

updated to latest swift (3) #76

merged 1 commit into from
Aug 18, 2016

Conversation

MarvinNazari
Copy link
Contributor

No need to merge now, there is one issue on NSExtensionContextApplicationCallerTests, i commented out for now

@Mazyod
Copy link
Member

Mazyod commented Aug 5, 2016

Amazing work, thanks! I'll also hopefully spend time before Swift 3 comes out to study the changes to make sure everything is in the right place. This will be a burden to current users, since it's backward incompatible, but I agree that it should be necessary for the long run.

@Mazyod Mazyod mentioned this pull request Aug 17, 2016
Closed
@Mazyod
Copy link
Member

Mazyod commented Aug 17, 2016

The demand for Swift 3 support has increased, so it probably makes sense to merge this with the swift-3 branch on this repo. Do you think you're still able to make it? We're not in a rush yet, btw :)

@MarvinNazari MarvinNazari changed the base branch from master to swift-3 August 17, 2016 10:10
@MarvinNazari
Copy link
Contributor Author

@Mazyod i haven't checked this with the new beta yet, gonna do it later tonight 👍

@MarvinNazari
Copy link
Contributor Author

@Mazyod just checked with the latest beta and everything works :)

@Mazyod Mazyod merged commit 043dede into SwiftKitz:swift-3 Aug 18, 2016
@Mazyod
Copy link
Member

Mazyod commented Aug 18, 2016

Much obliged, Sir!

@Dreamersoul
Copy link
Member

So swift 3 works on appz:master? If so should we update the badge in the readme file?

@MarvinNazari
Copy link
Contributor Author

@Dreamersoul no, it's swift-3

@Maryom Maryom mentioned this pull request Sep 21, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blocked refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarvinNazari @Mazyod @Dreamersoul