[Enhancement]: Ventura-style Settings overhaul #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follows macOS Ventura settings style, enabled by default
turns out the selector still worked, just under a new name refactor: user footer to be closer in styling to the official client’s one
force-unwrapping an optional to find the underlying Settings NSWindow caused a crash on macOS 12 fixes #144
As far as possible, the Form + Section pattern has been used for all settings views
patch(settings): update sidebar icon for “voice and video”
…no title Just like macOS’ system settings
* fix some UI issues in the Accessibility page * move sidebar toggle hide code to View extension
|
Looking back at where we were, it certainly looks way more polished now XD
|
|
I'd like to specially thank the amazing folks at CodeEdit, the corresponding PR has hinted me in the right direction especially in the last few commits! PS: This PR actually started as a test bed for a contribution to CodeEdit, unfortunately I never got the time to merge my code into the CE codebase so I just passed them what I had worked on thus far it's been kindly merged in and built on by some really great devs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overhauls Swiftcord's settings to closely match macOS Ventura's new settings style. Adopting
Screenshots
Some eye-candy 👁️🍬
Account
Appearance
About
Credits
Debug
The behaviour of the Settings window and navigation is complete, however the detail views themselves still need some work.
Resolves #142