Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the same function withoutDuplicates() in Array Extension #1224

Closed
wants to merge 7 commits into from

Conversation

fallwd
Copy link
Contributor

@fallwd fallwd commented Dec 2, 2024

Checklist

  • [x ] I checked the Contributing Guidelines before creating this request.
  • [ x] New extensions are written in Swift 5.6.
  • [x ] New extensions support iOS 12.0+ / tvOS 12.0+ / macOS 10.13+ / watchOS 4.0+, or use @available if not.
  • I have added tests for new extensions, and they passed.
  • [x ] All extensions have a clear comments explaining their functionality, all parameters and return type in English.
  • [x ] All extensions are declared as public.
  • [x ] I have added a changelog entry describing my changes.

fallwd and others added 7 commits November 19, 2024 22:01
initializedCount should be equal to the number of successfully initialized elements.
update changelog
remove the same function. withoutDuplicates() is the same of removeDuplicates() in Array Extension
update changelog
@guykogus
Copy link
Contributor

@fallwd where do you see this duplicated? You're just removing functionality here...

@fallwd
Copy link
Contributor Author

fallwd commented Dec 13, 2024

@fallwd where do you see this duplicated? You're just removing functionality here...

sorry, I'll close.

@fallwd fallwd closed this Dec 13, 2024
@SwifterSwiftBot
Copy link

1 Message
📖 Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

Generated by 🚫 Danger

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.17%. Comparing base (c4571a9) to head (3217dd5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1224      +/-   ##
==========================================
- Coverage   68.22%   68.17%   -0.05%     
==========================================
  Files          98       98              
  Lines        3647     3642       -5     
==========================================
- Hits         2488     2483       -5     
  Misses       1159     1159              
Flag Coverage Δ
macos 97.06% <ø> (-0.01%) ⬇️
tvos 58.98% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants