Exercise Javier Gonzalez #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 19, 2021 18:59
Set up architecture to support SOLID principles. Using latest architecture components for navigation, asynchronous calls, observables, DI, mvvm support, appcompat In progress: exposing network status & dynamic display blocks
Saving Network response into a mock db just for personal practice. Create network service for fetching managers specials Added class that contains both canvas units and specials list
Removed unneeded scope from MainActivity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Team,
In this project you will find I tried using SOLID principles combined with MVVM architecture recommended by Google. The UI requirements are INCOMPLETE as I couldn't find a good way to elegantly meet these requirements. However, I hope the rest of the projects show cases the readability, test-ability, and scalability requirements.
The entry point for the app is the MainActivity which inflates a navigation view. This navigation view loads the Manager's Specials fragment which contains a simple recycler view and grid layout.
The MainActivity also fires a repeating function that polls the network every 10 seconds. You will find in the comments I mentioned an alternative more realistic real world solution that doesn't rely on guessing best polling repeat speed.
I'm separating the project into app and core modules, core containing interfaces and models for our pure business logic. And everything else (presentation/framework) going inside app.
I created a simple repository that mocks the use of a local storage system, however more used for my own practice rather than to meet project requirements. All data is still fetched fresh from the network service every-time.