Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Installing 5.10 (not 5.10.0) fails now that Swift 5.10.1 is released #315

Closed
dabrahams opened this issue Sep 17, 2024 · 14 comments · Fixed by #317
Closed

[Bug] Installing 5.10 (not 5.10.0) fails now that Swift 5.10.1 is released #315

dabrahams opened this issue Sep 17, 2024 · 14 comments · Fixed by #317
Labels
bug Something isn't working

Comments

@dabrahams
Copy link

See https://github.com/hylo-lang/hylo/actions/runs/10908612094/job/30274991314#step:4:1

@dabrahams dabrahams added the bug Something isn't working label Sep 17, 2024
@soumyamahunt
Copy link
Contributor

@dabrahams I am looking into the caching breaking for newer Xcode toolchains, meanwhile you can disable caching for now.

@dabrahams
Copy link
Author

Oh. If I just delete the old caches will that fix it, or do I actually need to disable them? And how do I disable the cache for this action? I don't see anything in the README

@dabrahams
Copy link
Author

dabrahams commented Sep 18, 2024

Never mind; I see it here.

@soumyamahunt
Copy link
Contributor

Oh. If I just delete the old caches will that fix it, or do I actually need to disable them?

Just deleting will result in immediate workflow to succeed but since it will generate new cache that will fail subsequent workflows.

And how do I disable the cache for this action? I don't see anything in the README

The inputs are documented in action.yml file, and README does mention to go through this file for list of inputs supported. The input name is cache-snapshot.

dabrahams added a commit to hylo-lang/hylo that referenced this issue Sep 18, 2024
dabrahams added a commit to hylo-lang/Swifty-LLVM that referenced this issue Sep 18, 2024
dabrahams added a commit to hylo-lang/Durian that referenced this issue Sep 18, 2024
@dabrahams
Copy link
Author

dabrahams commented Sep 18, 2024

That
didn't work

Did I do it wrong?

@soumyamahunt
Copy link
Contributor

Thatdidn't work

Did you try deleting the cache and running the action with cache-snapshot false or without deleting the cache?
I think deleting the cache and running with cache-snapshot false should work.

@dabrahams
Copy link
Author

Yes, deleting the caches works, thanks. IMO it's a bug, or at least extremely hard to use, that the cache gets used when cache-snapshot is false, but that's for you to decide.

dabrahams added a commit to hylo-lang/Swifty-LLVM that referenced this issue Sep 18, 2024
dabrahams added a commit to hylo-lang/Durian that referenced this issue Sep 18, 2024
@soumyamahunt
Copy link
Contributor

@dabrahams can you try reenabling cache-snapshot to true and run your workflow twice (second trigger started once first is completed).

I am no longer able to reproduce this in my CI, now I am under the impression that this might be some issue from GitHub end.

@dabrahams
Copy link
Author

I can try; that will take some considerable time FWIW.

@soumyamahunt
Copy link
Contributor

I can try; that will take some considerable time FWIW.

I think you can ignore this, the issue seems to only affect macos-13 runner.

dabrahams added a commit to hylo-lang/hylo that referenced this issue Sep 18, 2024
dabrahams added a commit to hylo-lang/hylo that referenced this issue Sep 18, 2024
@dabrahams
Copy link
Author

Well, the jobs are re-running now. In case you're interested: https://github.com/hylo-lang/hylo/actions/runs/10927463998?pr=1597

@dabrahams
Copy link
Author

The second run with cache enabled worked. What does that mean?

@soumyamahunt
Copy link
Contributor

The second run with cache enabled worked. What does that mean?

The issue is due to from 5.10.1 macOS toolchain installation caching breaks across machine architecture, i.e action caches created from m series runners fail on intel machine and vice-versa. Next release will fix this issue.

@soumyamahunt
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants