Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace any fonts URL on build #951

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Toilal
Copy link
Contributor

@Toilal Toilal commented Dec 14, 2015

In distribution, fonts coming from bower dependencies are copied into dist/fonts directory by the fonts task.

Problem is that CSS can reference those fonts. There are some hardcoded cases based on frameworks supported by the generator, but it won't work for other libraries that user can add to bower later.

Using a regex in $.replace call, it will fix any bower_components fonts url and be consistent with fonts task from build.js.

@Toilal
Copy link
Contributor Author

Toilal commented Dec 14, 2015

There's something wrong with the replacement, it's still a work in progress ...

@Toilal Toilal force-pushed the fonts-replace branch 2 times, most recently from 79f9b07 to aabb744 Compare December 14, 2015 14:30
@Toilal
Copy link
Contributor Author

Toilal commented Dec 14, 2015

OK, i've change regexp to be stronger, should be ok now ! It works in my use case using bootstrap.

@Swiip
Copy link
Owner

Swiip commented Mar 28, 2016

I reopen this. Your solution seems great. I'm willing to merge this but you have to rebase it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants