Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KVC complaint Swift 4.0 #71

Merged
merged 2 commits into from
Sep 19, 2017
Merged

KVC complaint Swift 4.0 #71

merged 2 commits into from
Sep 19, 2017

Conversation

JorgeDC
Copy link

@JorgeDC JorgeDC commented Sep 15, 2017

Add @objc attribute to make sure the ViewControllers are KVC complaint for 'swinjectRegistrationName' in Swift 4.0

@JorgeDC JorgeDC closed this Sep 18, 2017
@JorgeDC JorgeDC reopened this Sep 18, 2017
@yoichitgy yoichitgy changed the base branch from master to swift4 September 19, 2017 13:38
@yoichitgy yoichitgy added this to the v2.0.0-beta.1 milestone Sep 19, 2017
@yoichitgy
Copy link
Member

Thanks @JorgeDC for the PR👍 I merged it to swift4 branch. The CI failure should be fixed.

@yoichitgy yoichitgy merged commit 56afa99 into Swinject:swift4 Sep 19, 2017
@yoichitgy yoichitgy mentioned this pull request Sep 25, 2017
Merged
@yoichitgy yoichitgy modified the milestones: v2.0.0-beta.1, v1.2.0 Sep 25, 2017
@yoichitgy
Copy link
Member

Thanks @JorgeDC👍 I merged this PR into master with PR #74.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JorgeDC @yoichitgy