fix: migrate old session launchers #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is part of the following stack: Change managed by git-spice. |
Base automatically changed from
fix-do-not-create-storage-secrets-twice
to
release-amaltheas-migration
November 7, 2024 07:20
Panaetius
requested changes
Nov 7, 2024
...nku_data_services/migrations/versions/584598f3b769_expand_and_separate_environments_from_.py
Show resolved
Hide resolved
Panaetius
approved these changes
Nov 7, 2024
olevski
force-pushed
the
fix-migrate-old-session-launchers
branch
from
22815b9
to
fe63d95
Compare
|
There were weird things going when the template db was renku which is also what we use to run the server in the devcontainer. Somehow with this the authzed migrations were not fully running and things were breaking all over the place. Also if the template db is renku then when you test locally the state of the db will be carried over into every test rather than starting with a clean slate. |
Panaetius
approved these changes
Nov 7, 2024
olevski
added a commit
that referenced
this pull request
Nov 8, 2024
olevski
added a commit
that referenced
this pull request
Nov 11, 2024
olevski
added a commit
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.