feat: project viewed events to be tackled in chunks #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng dequeued events
jachro
had a problem deploying
to
renku-ci-gr-1729
GitHub Actions
Failure
jachro
had a problem deploying
to
renku-ci-gr-1729
GitHub Actions
Error
jachro
had a problem deploying
to
renku-ci-gr-1729
GitHub Actions
Failure
jachro
had a problem deploying
to
renku-ci-gr-1729
GitHub Actions
Failure
eikek
approved these changes
Oct 5, 2023
|
|
||
| private def returnToQueue(de: DequeuedEvent): Throwable => F[Unit] = | ||
| Logger[F].error(_)(show"$categoryName: persisting event failed: ${de.id}; returning to the queue") >> | ||
| eventsDequeuer.returnToQueue(de) |
There was a problem hiding this comment.
It sounds a bit strange to me to have separate interfaces for deqeue and enqueue but then the dequeue also puts something into the queue?
| import io.renku.triplesstore.{ProjectsConnectionConfig, SparqlQueryTimeRecorder} | ||
| import org.typelevel.log4cats.Logger | ||
|
|
||
| private trait EventProcessor[F[_]] extends Pipe[F, DequeuedEvent, DequeuedEvent] |
There was a problem hiding this comment.
Wondering why we need to return an event - so why it's not Pipe[F, Event, Unit], more of a sink?
| SqlStatement | ||
| .named(s"$queryPrefix stats") | ||
| .select[Void, (CategoryName, Long)]( | ||
| sql"""SELECT category, COUNT(id) AS count |
There was a problem hiding this comment.
Since we have now the stuff in the DbInfra object, we could use it here as well maybe?
| SqlStatement | ||
| .named(s"$queryPrefix insert") | ||
| .command[CategoryName *: String *: OffsetDateTime *: OffsetDateTime *: EnqueueStatus *: EmptyTuple]( | ||
| sql"""INSERT INTO enqueued_event (category, payload, created, updated, status) |
There was a problem hiding this comment.
Also here it seems we could use references to DbInfra perhaps?
eikek
reviewed
Oct 5, 2023
| private[viewed] def kickOffEventsDequeueing[F[_]: Async: Logger](dequeuer: EventsDequeuer[F], | ||
| processor: EventProcessor[F] | ||
| ) = Async[F].start { | ||
| Logger[F].info(show"Starting events enqueuer for $categoryName") >> |
There was a problem hiding this comment.
Is this a typo: "Starting events enqueuer" -> "Starting events dequeuer" ?
jachro
had a problem deploying
to
renku-ci-gr-1729
GitHub Actions
Failure
jachro
had a problem deploying
to
renku-ci-gr-1729
GitHub Actions
Failure
jachro
had a problem deploying
to
renku-ci-gr-1729
GitHub Actions
Failure
jachro
had a problem deploying
to
renku-ci-gr-1729
GitHub Actions
Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new queue-like mechanism to deal with the ProjectViewed events in chunks instead of separately.
/deploy
closes #1649