Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improved failure reporting on unknown errors on event sending #1799

Merged
merged 1 commit into from
Nov 24, 2023
Merged

fix: improved failure reporting on unknown errors on event sending #1799

merged 1 commit into from
Nov 24, 2023

Conversation

jachro
Copy link
Contributor

@jachro jachro commented Nov 23, 2023

This PR:

  • slightly improves exception handling in cases when an unknown/unexpected exception is thrown when sending an event to another service. Simply a nasty MatchError is turned into an Exception with a better message and the real cause.

closes #1790

@jachro jachro requested a review from a team as a code owner November 23, 2023 18:50
eikek
eikek approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@eikek eikek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏼

@jachro jachro merged commit 87b6849 into development Nov 24, 2023
12 checks passed
@jachro jachro deleted the 1790-improved-exception-reporting-on-event-sending branch November 24, 2023 08:06
@jachro jachro mentioned this pull request Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eikek eikek eikek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MatchError on 500 when CES sends event to EL
2 participants
@jachro @eikek