Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TG not to write to TS until all exclusive migrations are run #1807

Merged
merged 5 commits into from
Nov 30, 2023
Merged

fix: TG not to write to TS until all exclusive migrations are run #1807

merged 5 commits into from
Nov 30, 2023

Conversation

jachro
Copy link
Contributor

@jachro jachro commented Nov 29, 2023 •
edited
Loading

This PR:

  • introduces a concept of an exclusive TS migration;
  • changes the precondition check causing events to be pushed back until all the exclusive migrations are done;
  • DATASET_VIEWED, PROJECT_ACTIVATED and PROJECT_VIEWING_DELETION to be guarded by the same precondition check;
  • adds a check preventing PROJECT_VIEWED events from being dequeued until all the exclusive migrations are done;

/deploy

@jachro jachro temporarily deployed to renku-ci-gr-1807 November 30, 2023 13:44 — with GitHub Actions Inactive
@RenkuBot
Copy link
Collaborator

You can access the deployment of this PR at https://renku-ci-gr-1807.dev.renku.ch

@jachro jachro marked this pull request as ready for review November 30, 2023 14:10
@jachro jachro requested review from a team as code owners November 30, 2023 14:10
@jachro jachro deployed to renku-ci-gr-1807 November 30, 2023 14:11 — with GitHub Actions Active
eikek
eikek approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@eikek eikek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏼

@jachro jachro merged commit 0280f20 into development Nov 30, 2023
17 of 18 checks passed
@jachro jachro deleted the ts-migration-to-run-in-isolation branch November 30, 2023 15:45
@jachro jachro mentioned this pull request Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eikek eikek eikek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jachro @RenkuBot @eikek