Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Update renku actions to v0.4.1 #820

Merged
merged 4 commits into from
Jan 18, 2022

Conversation

olevski
Copy link
Member

@olevski olevski commented Jan 17, 2022

Automated changes by create-pull-request GitHub action
/deploy

@olevski olevski requested a review from a team as a code owner January 17, 2022 10:01
jachro
jachro previously approved these changes Jan 17, 2022
Copy link
Contributor

@jachro jachro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tasko.

@olevski olevski marked this pull request as draft January 17, 2022 10:07
@olevski olevski changed the title chore(ci): Update renku actions to v0.4.0 chore(ci): Update renku actions to v0.4.1 Jan 18, 2022
@olevski olevski marked this pull request as ready for review January 18, 2022 12:46
@olevski
Copy link
Member Author

olevski commented Jan 18, 2022

The setup is as follows:

  • if you do not provide #persist in the PR description (i.e. like /deploy #persist) then the CI deployment is deleted after the acceptance tests complete
  • if you provide #persist the deployment is kept until the PR is closed.
  • when the PR is closed the namespace of the deployment is also deleted
  • when the acceptance tests complete AND #persist is not used the CI deployment is deleted but the namespace is not deleted in k8s - this makes it possible to reuse the TLS secret and not hit the limits for requesting certs with letsencrypt - when the acceptance tests for the same PR are run many times
  • artifacts from the acceptance tests are managed by the single (composite) test-renku action

@olevski olevski temporarily deployed to renku-ci-gr-820 January 18, 2022 12:57 Inactive
jachro
jachro previously approved these changes Jan 18, 2022
@RenkuBot
Copy link
Collaborator

You can access the deployment of this PR at https://renku-ci-gr-820.dev.renku.ch

@olevski olevski temporarily deployed to renku-ci-gr-820 January 18, 2022 14:23 Inactive
@olevski
Copy link
Member Author

olevski commented Jan 18, 2022

@jachro sorry this is the last change that was needed. No the test deployment will be deleted when the acceptance tests complete if you do not set the #persist flag.

Copy link
Contributor

@jachro jachro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@olevski
Copy link
Member Author

olevski commented Jan 18, 2022

The action is functioning as expected. The failure in the acceptance tests is a fluke and it is not affected at all by the changes in the PR. Nevertheless I will rerun the workflow so that I merge on all green.

@olevski olevski deployed to renku-ci-gr-820 January 18, 2022 16:54 Active
@olevski olevski merged commit cdb8124 into master Jan 18, 2022
@jachro jachro deleted the chore-update-renku-action-v0.4.0 branch May 18, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants