Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: GET projects/:path to work with any valid token if public project #852

Merged
merged 1 commit into from
Feb 8, 2022
Merged

fix: GET projects/:path to work with any valid token if public project #852

merged 1 commit into from
Feb 8, 2022

Conversation

jachro
Copy link
Contributor

@jachro jachro commented Feb 7, 2022

Currently, the GET projects/:path returns 500 if called with a valid access token although not for the project. Conversely, the resource works fine if you call it with no token at all. This PR makes both cases work the same.

@jachro jachro requested a review from a team as a code owner February 7, 2022 18:03
@jachro jachro merged commit fec7d2e into development Feb 8, 2022
@jachro jachro deleted the project-details-security-tweak branch February 8, 2022 09:06
jachro added a commit that referenced this pull request Feb 8, 2022
@jachro
chore: features for 2.1.2 (#854)
9e99ab0 
* fix: GET projects/:path to work with any valid access token if public project (#852)

* fix: member email finding algorithm to check up to 30 pages of project events (#853)

* chore: CLI upgraded to 1.0.5

* docs: added project re-provisioning explanations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joke1196 joke1196 joke1196 approved these changes

Assignees
No one assigned
Labels
important knowledge-graph
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jachro @joke1196