fix: do not add storage mounts patches when a session has no repository #1892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can access the deployment of this PR at https://renku-ci-nb-1892.dev.renku.ch |
Panaetius
approved these changes
May 28, 2024
leafty
added a commit
to SwissDataScienceCenter/renku
that referenced
this pull request
May 30, 2024
`renku-notebooks` bugfix release 1.25.1 brings in the following fixes: * fix: do not add storage mounts patches when a session has no repository (#1892)[SwissDataScienceCenter/renku-notebooks#1892]
leafty
added a commit
to SwissDataScienceCenter/renku
that referenced
this pull request
May 30, 2024
`renku-notebooks` bugfix release 1.25.1 brings in the following fixes: * fix: do not add storage mounts patches when a session has no repository ([#1892](SwissDataScienceCenter/renku-notebooks#1892))
Panaetius
pushed a commit
to SwissDataScienceCenter/renku
that referenced
this pull request
Jun 5, 2024
`renku-notebooks` bugfix release 1.25.1 brings in the following fixes: * fix: do not add storage mounts patches when a session has no repository ([#1892](SwissDataScienceCenter/renku-notebooks#1892))
olevski
pushed a commit
to SwissDataScienceCenter/renku
that referenced
this pull request
Jun 5, 2024
`renku-notebooks` bugfix release 1.25.1 brings in the following fixes: * fix: do not add storage mounts patches when a session has no repository ([#1892](SwissDataScienceCenter/renku-notebooks#1892))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1891.
Also moves conditions for empty patches inside their respective functions.
/deploy renku=master