-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design changes for Renku 2.0 #3214
Conversation
You can access the deployment of this PR at https://renku-ci-ui-3214.dev.renku.ch |
1fd750c
to
baf4f16
Compare
baf4f16
to
d0c4255
Compare
* remove v1 Bootstrap customization and add minimal styling to Bootstrap components. * swap components with custom CSS classes for standard Bootstrap components. * remove or modify a few interactions on the landing page and the project page --------- Co-authored-by: Andrea Cordoba <dandrea.cordoba@gmail.com>
1f3b742
to
6657e30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some early comments about bootstrap icons and overrides.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More comments.
client/src/features/ProjectPageV2/ProjectPageContent/DataSources/DataSourcesBox.tsx
Outdated
Show resolved
Hide resolved
@andre-code thank you for your review! For all your comments, I've either 1) addressed it or 2) added it to the second round of design changes or 3) added an inline comment (below this message for non-inline comments). Please give it a look. 1, 2: Done
Currently, all the off-canvas elements have the same width. Making it larger for sessions won't help much -- we have a lot of vertical content, but expanding horizontally won't fit more elements and users will need to scroll anyway. For this reason, I prefer to keep it consistent with all the other off-canvas. We can revise this later if we wish to re-think how we display the content there.
The space there seems a little limited to add more info. We could think about opening the Code repositories off-canvas on click. If we do that, we should add the same interaction for the other elements on the page (data source, launcher, ...). I would rather discuss this change with the product team since it will require a bit of work. 5: That's planned for the second round of design changes. 6, 7, 8, 9: Good point! I'll check into those with Jimena during the second round of design changes. Thank you for bringing those up!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leafty For the alerts, we considered that the content is unlikely to be very long. In principle, I agree with your comment and I will bring this up again, but I would rather address this later since the topic has been discussed already and there are a few other details we would like to address for the alerts (E.G. using non-filled icons and match the color we use for the text) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Tearing down the temporary RenkuLab deplyoment for this PR. |
New design for Renku 2.0 pages based on Bootstrap v5.3 components SwissDataScienceCenter/renku-ui#3214
* chore: Update changelog title for 0.56.0 release * refactor: revamp design for Renku 2.0 (#3726) New design for Renku 2.0 pages based on Bootstrap v5.3 components SwissDataScienceCenter/renku-ui#3214 * feat: upgrade Amalthea to 0.12.2 (#3724) Co-authored-by: Alessandro Degano <a.degano@gmail.com> * feat!: add platform configuration (#3716) --------- Co-authored-by: Lorenzo Cavazzi <43481553+lorenzo-cavazzi@users.noreply.github.com> Co-authored-by: Alessandro Degano <a.degano@gmail.com> Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>
Revamp the design, dropping most of the old Bootstrap customization used for v1 in favor of a new minimal set of customizations and dropping a bunch of custom components in favor of standard Bootstrap components.
Mind that this also impacts v1 for a few shared components. E.G. alerts, 404/error pages, ...
Some shared components still need to be re-implemented (E.G. in the project settings page), but there will soon be a follow-up PR.
Notion page reference
/deploy