-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update project creation #3399
Conversation
You can access the deployment of this PR at https://renku-ci-ui-3399.dev.renku.ch |
client/src/features/ProjectPageV2/ProjectPageContent/Settings/ProjectSettings.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more comments here 👇 .
The PR is overall good, but form code needs to be improved.
@leafty thank you for the review! I either updated the code as suggested or dropped an inline content. Most points are solved or trivial to solve after a confirmation (E.G: |
* use hashes to store the open state * drop the projectV2 slice
… design to input to change the slug
c975321
to
375174b
Compare
Thanks @leafty, copy approved by Product team |
Tearing down the temporary RenkuLab deplyoment for this PR. |
This PR updates the project and group creation pages, which are now available as modals.
The settings pages have been updated accordingly, but they will undergo further updates in another pitch.
Reference: https://www.notion.so/renku/Clean-up-Project-Group-Creation-0bee33f12b624525a100df79327eb5e7
/deploy renku=release-0.62.0