Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update project creation #3399

Merged
merged 31 commits into from
Dec 16, 2024
Merged

feat: update project creation #3399

merged 31 commits into from
Dec 16, 2024

Conversation

lorenzo-cavazzi
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi commented Nov 13, 2024

This PR updates the project and group creation pages, which are now available as modals.
The settings pages have been updated accordingly, but they will undergo further updates in another pitch.

Reference: https://www.notion.so/renku/Clean-up-Project-Group-Creation-0bee33f12b624525a100df79327eb5e7

image

image

/deploy renku=release-0.62.0

@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3399.dev.renku.ch

Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments here 👇 .

The PR is overall good, but form code needs to be improved.

@lorenzo-cavazzi
Copy link
Member Author

@leafty thank you for the review!

I either updated the code as suggested or dropped an inline content. Most points are solved or trivial to solve after a confirmation (E.G: Group vs GroupV2).
The one outstanding is "how to treat routes" / "where to put modals". I'm happy to talk about it offline to explain the requirements better and understand your proposed solution.

@andre-code
Copy link
Contributor

andre-code commented Dec 16, 2024

If needed, the copy for error messages should be checked with a native English speaker from the product team.

Thanks @leafty, copy approved by Product team

@andre-code andre-code requested a review from leafty December 16, 2024 14:59
@andre-code andre-code merged commit c71019f into main Dec 16, 2024
19 checks passed
@andre-code andre-code deleted the lorenzo/project-group-creation branch December 16, 2024 15:40
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants