chore: run UI client without telepresence #3506
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the ui client to run locally and target any other Renku deployment as long as the gateway cookie settings on the target deployment are loose enough. But we can make it so that on CI deployments this is the case.
olevski
temporarily deployed
to
renku-ci-ui-3506
GitHub Actions
Inactive
|
You can access the deployment of this PR at https://renku-ci-ui-3506.dev.renku.ch |
|
@olevski I will have a look 👀 . |
|
@leafty this is still wip |
olevski
changed the title
olevski
temporarily deployed
to
renku-ci-ui-3506
GitHub Actions
Inactive
|
OK, I am not sure how this can work without being limited by CORS, Secure Context, secure cookies, etc. |
Yeah that is what I am trying to figure out rn. |
olevski
temporarily deployed
to
renku-ci-ui-3506
GitHub Actions
Inactive
olevski
had a problem deploying
to
renku-ci-ui-3506
GitHub Actions
Failure
olevski
force-pushed
the
chore-run-ui-client-without-telepresence
branch
from
8920dfd to
6699f0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All you need to do is
RENKU_BASE_URL=https://dev.renku.ch npm run startand the ui will talk to the backend from that deployment.Note that the session cookies issued by the gateway are tied to the host or something like that. So when you run on localhost you cannot actually log in. But we can add (or there already is) a setting on the gateway that will make it issue weaker cookies in dev. Then one can just run
/deploy values=gateway.weakCookies=truein a PR and point your local ui client at that deployment and everything should work. Will do just a bit more testing to see that that is the case.But I can already look at the renku home page and even complete the login flow wihtout doing anything on the gateway. But for now the session cookie is not there.