Skip to content

Update navbars / add banner on v1 dashboard #3526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 30, 2025
Merged

Update navbars / add banner on v1 dashboard #3526

merged 3 commits into from
Apr 30, 2025

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented Feb 6, 2025 •
edited
Loading

Legacy Navbar
image

Navbar
image

/deploy renku=ciyer/urls-v1-v2

@ciyer ciyer force-pushed the ciyer/v2-navbars branch 3 times, most recently from d4f105a to 4fbdca3 Compare February 7, 2025 12:01
@ciyer ciyer temporarily deployed to renku-ci-ui-3526 February 7, 2025 12:20 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

RenkuBot commented Feb 7, 2025

You can access the deployment of this PR at https://renku-ci-ui-3526.dev.renku.ch

@ciyer ciyer temporarily deployed to renku-ci-ui-3526 February 17, 2025 09:22 — with GitHub Actions Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-3526 February 17, 2025 10:54 — with GitHub Actions Inactive
@ciyer ciyer marked this pull request as ready for review February 17, 2025 13:20
@ciyer ciyer requested a review from a team as a code owner February 17, 2025 13:20
@ciyer ciyer temporarily deployed to renku-ci-ui-3526 February 20, 2025 15:52 — with GitHub Actions Inactive
leafty
leafty reviewed Feb 20, 2025
View reviewed changes
Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it normal that the new legacy navbar only shows up for logged in users?

@leafty leafty self-assigned this Feb 20, 2025
@ciyer ciyer marked this pull request as draft March 5, 2025 09:05
@ciyer ciyer force-pushed the build/urls-v1-v2 branch from e887f90 to 8478761 Compare March 18, 2025 09:21
@ciyer ciyer force-pushed the ciyer/v2-navbars branch from 8846015 to 55d7490 Compare March 18, 2025 09:26
@ciyer ciyer force-pushed the build/urls-v1-v2 branch from 8478761 to ccabf15 Compare March 24, 2025 08:20
@ciyer ciyer force-pushed the ciyer/v2-navbars branch from 55d7490 to fe0e3f8 Compare March 24, 2025 08:41
@ciyer ciyer force-pushed the build/urls-v1-v2 branch from ccabf15 to bee5e2d Compare March 24, 2025 10:15
@ciyer ciyer force-pushed the ciyer/v2-navbars branch from fe0e3f8 to c1459d4 Compare March 24, 2025 10:18
@ciyer ciyer force-pushed the build/urls-v1-v2 branch from bee5e2d to 74ad8c8 Compare March 26, 2025 10:29
@ciyer ciyer force-pushed the ciyer/v2-navbars branch from c1459d4 to f42d003 Compare March 27, 2025 10:18
@ciyer ciyer force-pushed the build/urls-v1-v2 branch from 5648aee to 582d74a Compare April 11, 2025 15:21
@ciyer ciyer force-pushed the ciyer/v2-navbars branch from c0a64de to dfa6a58 Compare April 11, 2025 15:23
@ciyer ciyer temporarily deployed to renku-ci-ui-3526 April 11, 2025 15:23 — with GitHub Actions Inactive
@ciyer ciyer requested a review from leafty April 14, 2025 07:18
leafty
leafty reviewed Apr 14, 2025
View reviewed changes
Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is OK.

How do you switch between legacy and 2.0 as an anonymous user? I cannot find a button or link to do so in the navbar.

This is still unsolved.

@ciyer
Copy link
Contributor Author

ciyer commented Apr 14, 2025

How do you switch between legacy and 2.0 as an anonymous user? I cannot find a button or link to do so in the navbar.

This is still unsolved.

I have asked the prod team for clarification on how they want this handled.

@ciyer ciyer force-pushed the build/urls-v1-v2 branch from 582d74a to b225011 Compare April 15, 2025 09:30
@ciyer ciyer force-pushed the ciyer/v2-navbars branch from dfa6a58 to 2862805 Compare April 15, 2025 09:30
@ciyer ciyer temporarily deployed to renku-ci-ui-3526 April 15, 2025 09:30 — with GitHub Actions Inactive
@ciyer ciyer force-pushed the build/urls-v1-v2 branch from b225011 to 8157597 Compare April 23, 2025 08:45
@ciyer ciyer force-pushed the ciyer/v2-navbars branch from 2862805 to 08d607f Compare April 23, 2025 08:45
@ciyer ciyer temporarily deployed to renku-ci-ui-3526 April 23, 2025 09:19 — with GitHub Actions Inactive
@ciyer ciyer force-pushed the build/urls-v1-v2 branch from 8157597 to f2d074e Compare April 29, 2025 08:05
@ciyer ciyer force-pushed the ciyer/v2-navbars branch from 08d607f to f3be90b Compare April 29, 2025 08:07
@ciyer
Copy link
Contributor Author

ciyer commented Apr 29, 2025

Code is OK.

How do you switch between legacy and 2.0 as an anonymous user? I cannot find a button or link to do so in the navbar.

This is still unsolved.

The prod team is working on a design to handle this, but they do not want this issue to block progress. When the design is finished, it will be implemented in another PR.

@ciyer ciyer merged commit 102d996 into build/urls-v1-v2 Apr 30, 2025
18 checks passed
@ciyer ciyer deleted the ciyer/v2-navbars branch April 30, 2025 07:42
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

ciyer added a commit that referenced this pull request Apr 30, 2025
@ciyer
minor: remove WIP badge from V1 secrets (#3526)
781ddc5
ciyer added a commit that referenced this pull request Apr 30, 2025
@ciyer
refactor: update navbars for v2/legacy (#3526)
3862588
ciyer added a commit that referenced this pull request Apr 30, 2025
@ciyer
feat: add v2 announcement banner on v1 dashboard (#3526)
ea39667
ciyer added a commit that referenced this pull request May 2, 2025
@ciyer
minor: remove WIP badge from V1 secrets (#3526)
064ad86
ciyer added a commit that referenced this pull request May 2, 2025
@ciyer
refactor: update navbars for v2/legacy (#3526)
c622dd1
ciyer added a commit that referenced this pull request May 2, 2025
@ciyer
feat: add v2 announcement banner on v1 dashboard (#3526)
eec79b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leafty leafty leafty approved these changes

Assignees

@leafty leafty

Labels
ShapeUp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ciyer @RenkuBot @leafty @lorenzo-cavazzi