Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update navbars / add banner on v1 dashboard #3526

Open
wants to merge 4 commits into
base: build/urls-v1-v2
Choose a base branch
from

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented Feb 6, 2025

Legacy Navbar
image

Navbar
image

/deploy renku=ciyer/urls-v1-v2

@ciyer ciyer force-pushed the ciyer/v2-navbars branch 3 times, most recently from d4f105a to 4fbdca3 Compare February 7, 2025 12:01
@ciyer ciyer temporarily deployed to renku-ci-ui-3526 February 7, 2025 12:20 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

RenkuBot commented Feb 7, 2025

You can access the deployment of this PR at https://renku-ci-ui-3526.dev.renku.ch

@ciyer ciyer temporarily deployed to renku-ci-ui-3526 February 17, 2025 09:22 — with GitHub Actions Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-3526 February 17, 2025 10:54 — with GitHub Actions Inactive
@ciyer ciyer marked this pull request as ready for review February 17, 2025 13:20
@ciyer ciyer requested a review from a team as a code owner February 17, 2025 13:20
Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it normal that the new legacy navbar only shows up for logged in users?

@leafty leafty self-assigned this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants