Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(charts): cert management security context #3699

Open
wants to merge 11 commits into
base: release-0.60.0
Choose a base branch
from
Open

feat(charts): cert management security context #3699

wants to merge 11 commits into from

Conversation

JGodin-C2C
Copy link
Contributor

What

Allow security context to be setted in the cert init container. and introduce default configuration to be the as previous values

Why

This will allow to deploy this pod in a restricted PSS environment.

@JGodin-C2C JGodin-C2C requested a review from a team as a code owner June 28, 2024 11:32
feat(charts): cert management security context
d476ba0 
Allow security context to be setted in the cert init container. and
introduce default configuration to be the as previous values

Signed-off-by: Julien Godin <julien.godin@camptocamp.com>
@Panaetius Panaetius changed the base branch from master to release-0.60.0 October 9, 2024 14:29
@Panaetius Panaetius requested a review from a team as a code owner October 10, 2024 06:34
rokroskar
rokroskar requested changes Oct 11, 2024
View reviewed changes
Copy link
Member

@rokroskar rokroskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @JGodin-C2C! Could you please add a description of the changes in the values.yaml.changelog.md file?

@JGodin-C2C
Copy link
Contributor Author

Hello, eeer, so , i didnt find any documentation on how to follow your versions conventions. I Assumed it was linked to the 0.60.0 release.
Please correct me if i'm wrong.

aledegano
aledegano reviewed Oct 17, 2024
View reviewed changes
Copy link
Contributor

@aledegano aledegano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @JGodin-C2C , thank you for this PR.
I believe that it can easily go into 0.59.0.
I have just left a suggestion on the wording for the docs.

helm-chart/values.yaml.changelog.md Outdated Show resolved Hide resolved
helm-chart/values.yaml.changelog.md Outdated Show resolved Hide resolved
feat: Add helm changelog for certificates SecurityContext
49d318e 
Signed-off-by: Julien Godin <julien.godin@bit.admin.ch>
@JGodin-C2C
Copy link
Contributor Author

Thanks for the suggestions .
I squashed my commits, it is much cleaner that way.

@Panaetius Panaetius requested a review from a team as a code owner October 17, 2024 08:47
aledegano
aledegano reviewed Oct 17, 2024
View reviewed changes
CHANGELOG.rst
@@ -10,6 +10,7 @@



=======
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
=======

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be there and it's making the tests about the docs fail.

@aledegano
Copy link
Contributor

Can you please target the branch release-0.59.0, since we can easily merge this there.

@Panaetius Panaetius force-pushed the release-0.60.0 branch 3 times, most recently from 7502cda to ee8bbeb Compare October 28, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledegano aledegano aledegano left review comments

@Panaetius Panaetius Panaetius approved these changes

@rokroskar rokroskar Awaiting requested review from rokroskar

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JGodin-C2C @aledegano @Panaetius @rokroskar @RenkuBot @eikek